fix(hooks): bootstrap hook injects context via plain stdout - #6
Merged
Merged
Conversation
The SessionStart bootstrap hook emitted its nudge as a hookSpecificOutput additionalContext JSON object. Plain-text stdout is the documented way a SessionStart hook injects context Claude can see, so emit the nudge directly and drop the jq output call (jq is still used to read the stdin payload). Behavior is otherwise unchanged: silent unless a git repo lacks a root CLAUDE.md. Test asserts the plain-text nudge instead of parsing JSON.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe SessionStart bootstrap hook now prints its nudge as one plain-text stdout line instead of a JSON object. The behavioral test now validates the plain-text output while retaining the clean-exit check. ChangesSessionStart context output
Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
bootstrap-claude-md.shSessionStart hook emitted its nudge as ahookSpecificOutput.additionalContextJSON object. Per the current hooks docs,SessionStartis one of the events that inject context via plain-text stdout; that's the documented, unambiguous idiom. Switch to printing the nudge directly and drop thejqoutput call.jqis still required to read.cwdfrom the stdin payload.Behavior is unchanged: silent unless a git work tree (root != $HOME) lacks a root
CLAUDE.md; fail-open; never writes a file.Test plan
test-bootstrap-claude-md.sh(9 cases) updated to assert the plain-text nudge; passesSummary by CodeRabbit
Bug Fixes
Tests