Repository navigation
docs: add MHFU (ULUS10391) multiplayer test notes - #5
Closed
kissofkill wants to merge 4 commits into
Closed
kissofkill wants to merge 4 commits into
kissofkill wants to merge 4 commits into
Conversation
Documented test results for MHFU quest start using a remote relay, highlighting improvements and known limitations post-fix.
Removed complex closing logic for accepted connections in the socket operations.
Author
|
The latest update (990e875) added a fix for the same bug this PR was addressing (keeping accepted streams alive when the listener closes), so I've removed my transport change and updated this PR to contain only a docs addition. It adds the MHFU (ULUS10391) test results to docs/multiplayer-validation.md: the failure I saw before the fix, and a two-client test with 990e875 where the quest starts and the clients connect with no noticeable lag. Thanks for the quick fix! |
root-hunter
approved these changes
Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update:
Adds a validation entry for Monster Hunter Freedom Unite (ULUS10391) to docs/multiplayer-validation.md: the relay log signature and WebSocket behavior before the listener fix, and a two-client test with 990e875 where the quest starts and connects. The transport change originally in this PR is superseded by 990e875, so only the docs change remains.
Old:
Fixes #4
Some games (MHFU, ULUS10391) close their listening socket after accepting a connection. Accepted connections are multiplexed over the single /tcp-listen WebSocket, so closing the listener also tore down the already-accepted connection, and the relay then logged "Broken pipe" on the guest's /tcp-connect socket.
This change keeps the listener's WebSocket open after the game closes it, as long as accepted connections remain. It accepts no new connections, drops only the not-yet-accepted ones, and closes the WebSocket when the last accepted child closes. Control socket teardown and disconnect() still close everything.
Tested manually with one pair of players on MHFU (Firefox 158, self-hosted relay): a quest started and ran after the change.