docs: reflect merged fixes (#118, #119, #120) - #121
Merged
Merged
Conversation
- known-issues: mark #1 and #5 resolved, narrow #2 to the remaining env layout drift, update #3/#13 for the new common and domain tests - overview, CLAUDE.md, feature guide: drop the mapError warning, describe the API_URL fallback - testing, bootstrap customization: current test dirs and sonar.tests Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #117. It updates the docs now that the fix PRs have merged:
known-issues.md: Create Base GitHub Project #1 (fix(common): make ResultType.mapError invoke its callback #118) and Add Code examples fot Http Client #5 (fix(ios): point flavor xcconfigs at existing entrypoints #120) marked resolved, with numbers kept stable. Add Localization #2 narrowed to the remaining env-layout decision, sinceEnvConfig.apiUrlnow falls back toAPI_URL(fix(domain): fall back to unsuffixed API_URL in EnvConfig.apiUrl #119). Add Basic Theme Structure #3 and Initial config: Basic configuration #13 updated for the newcommonanddomaintests.CLAUDE.md,overview.md,feature-guide.md: removed the "mapErrornever calls its callback" warnings and described theAPI_URLfallback.testing.md,bootstrap-customization.md: the current test directories andsonar.tests.Docs only.
Issue
N/A
Preview
N/A
Notes:
Start ssh-agent(missingSSH_PRIVATE_KEYsecret), the same as onmain. See known-issues Add Basic Theme Structure #3.🤖 Generated with Claude Code