Skip to content

Reduce thread safety test output#232

Open
dlanov wants to merge 1 commit into
ros:rollingfrom
dlanov:reduce-thread-safety-test-output
Open

Reduce thread safety test output#232
dlanov wants to merge 1 commit into
ros:rollingfrom
dlanov:reduce-thread-safety-test-output

Conversation

@dlanov

@dlanov dlanov commented Jul 21, 2026

Copy link
Copy Markdown

Fixes #145.

Summary

The thread-safety stress tests created plugin instances across 500 threads and called saySomething() for every instance, flooding the test output with repeated plugin messages.

Keep the shared-pointer and unique-pointer construction and destruction stress intact, but remove the unnecessary output-producing method calls.

Testing

Validated in ros:rolling-ros-base:

  • colcon build --packages-select class_loader --cmake-args -DBUILD_TESTING=ON
  • colcon test --packages-select class_loader
  • 134 tests, 0 errors, 0 failures
  • ClassLoaderTest.threadSafety passed
  • ClassLoaderUniquePtrTest.threadSafety passed
  • git diff --check

Generative AI

Generative AI assisted with issue analysis, preparing the scoped edit, and test planning. I reviewed the complete diff and all test results.

Signed-off-by: Dennis Lanov <dennis.lanov@gmail.com>
@mergify

mergify Bot commented Jul 21, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ClassLoaderTest.threadSafety test is noisy

1 participant