Fix isLibraryLoaded per-loader scope#233
Open
dlanov wants to merge 1 commit into
Open
Conversation
Signed-off-by: Dennis Lanov <dennis.lanov@gmail.com>
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #173.
Summary
ClassLoader::isLibraryLoaded()is documented to report whether a library is loaded within the scope of that specific loader.The previous comparison used
<=when comparing the number of metaobjects owned by the loader with the total number of metaobjects for the library. Because the loader-owned metaobjects are a subset of the total, this could report the library as loaded for an on-demand loader that had not loaded it.Require the counts to match and add a regression test using two loaders for the same library. The test verifies that:
loadLibrary()Testing
Validated in
ros:rolling-ros-base:colcon build --packages-select class_loader --cmake-args -DBUILD_TESTING=ONcolcon test --packages-select class_loaderClassLoaderTest.isLibraryLoadedScopedToLoaderpassedgit diff --checkGenerative AI
Generative AI assisted with issue analysis, preparing the scoped edit, and test planning. I reviewed the complete diff and all test results.