chore(ci): add test workflow - #91
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0aabb578f4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5f2d776cc2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d8edc34712
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ed9fafee4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| rules: [ | ||
| { test: /\.css$/, type: 'css' }, | ||
| { test: /\.png$/, type: 'asset/resource' }, | ||
| { test: /partial\.html$/, type: 'asset/source' }, |
There was a problem hiding this comment.
When build-examples builds the javascript or javascript-advanced example, asset/source returns partial.html verbatim, including <img src="logo.png">; neither example entry imports that image, so no logo.png asset is emitted and the generated page has a broken image. The previous html-loader rule emitted the image and replaced this URL, so these partials still need asset-aware processing or an explicit emitted URL.
Useful? React with 👍 / 👎.
| module: { | ||
| rules: [ | ||
| { test: /\.css$/, type: 'css' }, | ||
| { test: /\.png$/, type: 'asset/resource' }, |
There was a problem hiding this comment.
When the sort-manually example is built, this rules list no longer processes template.html, so its <img src="logo.png"> remains unchanged while none of the entry modules imports the image; consequently the output omits the logo asset and both generated pages reference a missing file. Preserve the previous asset-aware HTML processing or explicitly import and interpolate the emitted logo URL.
Useful? React with 👍 / 👎.
1 participant
The repository's test workflow has been disabled since 2024, leaving pull requests without automated test coverage. This PR replaces the inactive workflow with a Test workflow aligned with
rsbuild-plugin-template, runningnode --run teston Ubuntu and Windows with Node.js 24.19.0. The workflow currently exposes existing test setup failures, which are intentionally left for follow-up changes.Related Links