chore: build the napi binding against the published rspack_resolver crate - #293
Draft
stormslowly wants to merge 1 commit into
Draft
chore: build the napi binding against the published rspack_resolver crate#293stormslowly wants to merge 1 commit into
stormslowly wants to merge 1 commit into
Conversation
…rate The resolver source now lives in rspack under `crates/rspack_resolver`, so this repository no longer needs its own copy. `napi/Cargo.toml` pins `rspack_resolver = "=0.102.0-beta.1"` from crates.io and the workspace shrinks to the binding alone.
stormslowly
force-pushed
the
refactor_use_resolver_crate
branch
from
August 20, 2026 11:36
cf12120 to
586f3f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The resolver source has moved into rspack (
crates/rspack_resolver), so keeping a second copy here means every fix has to be written twice. This repository now only owns the Node.js binding, and consumes the resolver as a pinned crates.io dependency:rspack_resolver = "=0.102.0-beta.1".Before: root package
rspack_resolver(src/, tests/, benches/, fuzz/) +napimember, released as both a crate and an npm package.After: virtual workspace with
members = ["napi"]; the crate is released from rspack, the npm package from here.What
napi/Cargo.toml:path = ".."→"=0.102.0-beta.1"Cargo.toml: virtual workspace, keeping only therelease/profilingprofilessrc/,tests/,benches/,examples/resolver.rs,fuzz/benchmark.yml,codecov.yml,fuzz.yml,release-plz.yml,release-plz.toml; droppedcargo publish --dry-run, the rustdoc job, thewasm32-unknown-unknownjob and thecargo teststeps fromci.ymldeny.toml: allowISC(libloading, pulled in bynapi) and ignore unpublished workspace crates. The Cargo Deny job is gated onCargo.lockchanges, so it had not actually run against these two pre-existing findings beforeREADME.md,CONTRIBUTING.md,CLAUDE.md) andjustfileupdated to the binding-only layoutVerified locally:
cargo check --locked,cargo clippy -- -D warnings,cargo fmt --check,taplo format --check,cargo shear,cargo deny check bans licenses sources,typos,prettier --list-different, andpnpm testafterpnpm run build:binding:debug(34 + 183 tests, 0 failures).