Skip to content

fix(resolver): restore tsconfig files as file dependencies - #294

Closed
stormslowly wants to merge 1 commit into
mainfrom
fix/restore-tsconfig-file-dependencies
Closed

fix(resolver): restore tsconfig files as file dependencies#294
stormslowly wants to merge 1 commit into
mainfrom
fix/restore-tsconfig-file-dependencies

Conversation

@stormslowly

Copy link
Copy Markdown
Collaborator

Reverts #291.

Why

#291 stopped add_file_dependency for tsconfig and its project references as a temporary workaround for memory usage in the consumer. The cost is correctness: tsconfig edits no longer invalidate watch builds, and the only test covering it (tsconfig_file_as_file_dependencies) had to be #[ignore]d.

The memory concern belongs on the consumer side (how the dependency set is stored per module), not here — the resolver should keep reporting what it actually read.

What

  • restore the for dependency in &tsconfig.file_dependencies loop in resolve_tsconfig
  • un-ignore tsconfig_file_as_file_dependencies

Copilot AI lite review requested due to automatic review settings August 21, 2026 05:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Restores tsconfig and project-reference file dependency reporting so watch builds invalidate correctly.

Changes:

  • Re-enables tsconfig dependency propagation in src/lib.rs.
  • Re-enables the corresponding regression test.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Summary
src/tests/tsconfig_project_references.rs Re-enables dependency coverage.
src/lib.rs Restores dependency reporting; introduces a critical downstream memory risk for large monorepos.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/lib.rs
@codspeed-hq

codspeed-hq Bot commented Aug 21, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 12 untouched benchmarks


Comparing fix/restore-tsconfig-file-dependencies (d6a0b1d) with main (ebed1eb)

Open in CodSpeed

@stormslowly stormslowly changed the title revert: restore tsconfig files as file dependencies fix(resolver): restore tsconfig files as file dependencies Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants