fix(resolver): restore tsconfig files as file dependencies - #294
Closed
stormslowly wants to merge 1 commit into
Closed
fix(resolver): restore tsconfig files as file dependencies#294stormslowly wants to merge 1 commit into
stormslowly wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Restores tsconfig and project-reference file dependency reporting so watch builds invalidate correctly.
Changes:
- Re-enables tsconfig dependency propagation in
src/lib.rs. - Re-enables the corresponding regression test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Summary |
|---|---|
src/tests/tsconfig_project_references.rs |
Re-enables dependency coverage. |
src/lib.rs |
Restores dependency reporting; introduces a critical downstream memory risk for large monorepos. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #291.
Why
#291 stopped
add_file_dependencyfor tsconfig and its project references as a temporary workaround for memory usage in the consumer. The cost is correctness: tsconfig edits no longer invalidate watch builds, and the only test covering it (tsconfig_file_as_file_dependencies) had to be#[ignore]d.The memory concern belongs on the consumer side (how the dependency set is stored per module), not here — the resolver should keep reporting what it actually read.
What
for dependency in &tsconfig.file_dependenciesloop inresolve_tsconfigtsconfig_file_as_file_dependencies