Skip to content

fix(types): avoid leaking load-config types#76

Merged
chenjiahan merged 1 commit into
mainfrom
chenjiahan/fix-load-config-types
Jul 22, 2026
Merged

fix(types): avoid leaking load-config types#76
chenjiahan merged 1 commit into
mainfrom
chenjiahan/fix-load-config-types

Conversation

@chenjiahan

Copy link
Copy Markdown
Member

Summary

The published rstack declarations currently reference @rstackjs/load-config, even though its runtime implementation is bundled and consumers should not need to install it.

This PR defines the config loader result shape within Rstack so the emitted declarations remain self-contained without adding a production dependency.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@chenjiahan, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 21 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 06534601-fe6c-408c-b86c-d87b4193da2b

📥 Commits

Reviewing files that changed from the base of the PR and between 2f6e3f6 and 6256d89.

📒 Files selected for processing (1)
  • packages/rstack/src/config.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chenjiahan/fix-load-config-types

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying rstack-cli with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6256d89
Status: ✅  Deploy successful!
Preview URL: https://5e2640a9.rstack-cli.pages.dev
Branch Preview URL: https://chenjiahan-fix-load-config-t.rstack-cli.pages.dev

View logs

@chenjiahan
chenjiahan merged commit 82a944f into main Jul 22, 2026
4 checks passed
@chenjiahan
chenjiahan deleted the chenjiahan/fix-load-config-types branch July 22, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant