Skip to content

fix(rspack-rsc): align React Server DOM type declarations#480

Merged
chenjiahan merged 1 commit into
mainfrom
fix-react-server-dom-rspack-types
Jul 20, 2026
Merged

fix(rspack-rsc): align React Server DOM type declarations#480
chenjiahan merged 1 commit into
mainfrom
fix-react-server-dom-rspack-types

Conversation

@SyMind

@SyMind SyMind commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • align react-server-dom-rspack declarations with the 0.0.2 runtime APIs
  • add missing client and server exports
  • update manifest-injected Node API signatures
  • use React DOM’s official ReactFormState type

@chenjiahan
chenjiahan enabled auto-merge (squash) July 20, 2026 09:14
@chenjiahan
chenjiahan merged commit 7ba8c94 into main Jul 20, 2026
4 checks passed
@chenjiahan
chenjiahan deleted the fix-react-server-dom-rspack-types branch July 20, 2026 09:15
@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a994dac1-dc7c-4d81-b27d-8f8180deed38

📥 Commits

Reviewing files that changed from the base of the PR and between dc32432 and 8a4bd7c.

📒 Files selected for processing (1)
  • rspack/rspack-rsc/types/react-server-dom-rspack.d.ts

📝 Walkthrough

Walkthrough

Updated RSC client declarations to make findSourceMapURL optional and add setServerCallback. Refactored server-node declarations with a new ServerEntry type, imported ReactFormState, simplified decode function parameters, added loadServerAction, removed server-edge re-exports, and updated renderToReadableStream options.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-react-server-dom-rspack-types

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants