Skip to content

fix: css import in tanstack-start example#485

Open
s-r-x wants to merge 1 commit into
rstackjs:mainfrom
s-r-x:main
Open

fix: css import in tanstack-start example#485
s-r-x wants to merge 1 commit into
rstackjs:mainfrom
s-r-x:main

Conversation

@s-r-x

@s-r-x s-r-x commented Jul 22, 2026

Copy link
Copy Markdown

in production build the start injects 2 css urls: 1 for the server build and 1 for the client one. the base urls are different, so, apparently, the server link is broken. the same happens to every asset imported with ?url, not only css.

there's an open PR, but it doesn't look like it's gonna be merged anytime soon.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0a185f7d-4d9a-4ed6-82e4-f93a88ebc877

📥 Commits

Reviewing files that changed from the base of the PR and between 87c1385 and 582a853.

📒 Files selected for processing (1)
  • rsbuild/tanstack-start/src/routes/__root.tsx

📝 Walkthrough

Walkthrough

The root route now imports styles.css as a side effect instead of importing it as a stylesheet URL. Its head() configuration no longer injects the stylesheet through a <link rel="stylesheet"> entry.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: fixing CSS import handling in the TanStack Start example.
Description check ✅ Passed The description describes the production build CSS URL issue that this change addresses.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants