Skip to content

Update hypb:in-string-p test#1017

Draft
matsl wants to merge 3 commits into
masterfrom
pr_add_tests_for_hypb_in-string-p
Draft

Update hypb:in-string-p test#1017
matsl wants to merge 3 commits into
masterfrom
pr_add_tests_for_hypb_in-string-p

Conversation

@matsl

@matsl matsl commented Jul 19, 2026

Copy link
Copy Markdown
Collaborator

What

Update hypb:in-string-p tests.

Why

Create usable tests while working on fixing different edge cases.

@matsl
matsl requested a review from rswgnu July 19, 2026 16:13
@matsl

matsl commented Jul 19, 2026

Copy link
Copy Markdown
Collaborator Author

@rswgnu Here is the updated tests for hypb:in-string-p. If you need other tests or modifications just comment in the PR and I'll try to update.

Comment thread test/hypb-tests.el Outdated
(goto-char pos)
(if (not response)
(progn
(ert-info ((format "Test #%d: At pos %d, char '%c', expected not within \"%s\" in mode: %s"

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rswgnu I missed to update the "not within" part to "outside" before creating the PR. I'll wait with this until next update or review comment.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply update when you have a chance. Instead of 'not within', it should say, 'outside string text'. When inside, 'inside string text'. That way, we know that there is no claim that it is on a delimiter. We're likely going to have to set up to test that as well after we cover the basics.
'

Comment thread test/hypb-tests.el Outdated
(goto-char pos)
(if (not response)
(progn
(ert-info ((format "Test #%d: At pos %d, char '%c', expected not within \"%s\" in mode: %s"

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply update when you have a chance. Instead of 'not within', it should say, 'outside string text'. When inside, 'inside string text'. That way, we know that there is no claim that it is on a delimiter. We're likely going to have to set up to test that as well after we cover the basics.
'

@matsl
matsl force-pushed the pr_add_tests_for_hypb_in-string-p branch from df86fbc to c0509a9 Compare July 19, 2026 22:21
@rswgnu

rswgnu commented Jul 22, 2026

Copy link
Copy Markdown
Owner

@matsl, I suggest you move all the string tests in one "string-tests.el" file so we can work with them there easily. I really need to see your changes here in one file to work with it easily before we merge.

@rswgnu

rswgnu commented Jul 22, 2026

Copy link
Copy Markdown
Owner

I have started looking at the string issues now and have a test function to add that shows when the in-string check of the Emacs (ppss) function differs from the result of hypb:in-string-p, making it easy to look at any descrepencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants