Update hypb:in-string-p test#1017
Conversation
|
@rswgnu Here is the updated tests for |
| (goto-char pos) | ||
| (if (not response) | ||
| (progn | ||
| (ert-info ((format "Test #%d: At pos %d, char '%c', expected not within \"%s\" in mode: %s" |
There was a problem hiding this comment.
@rswgnu I missed to update the "not within" part to "outside" before creating the PR. I'll wait with this until next update or review comment.
There was a problem hiding this comment.
Please apply update when you have a chance. Instead of 'not within', it should say, 'outside string text'. When inside, 'inside string text'. That way, we know that there is no claim that it is on a delimiter. We're likely going to have to set up to test that as well after we cover the basics.
'
| (goto-char pos) | ||
| (if (not response) | ||
| (progn | ||
| (ert-info ((format "Test #%d: At pos %d, char '%c', expected not within \"%s\" in mode: %s" |
There was a problem hiding this comment.
Please apply update when you have a chance. Instead of 'not within', it should say, 'outside string text'. When inside, 'inside string text'. That way, we know that there is no claim that it is on a delimiter. We're likely going to have to set up to test that as well after we cover the basics.
'
df86fbc to
c0509a9
Compare
|
@matsl, I suggest you move all the string tests in one "string-tests.el" file so we can work with them there easily. I really need to see your changes here in one file to work with it easily before we merge. |
|
I have started looking at the string issues now and have a test function to add that shows when the in-string check of the Emacs (ppss) function differs from the result of hypb:in-string-p, making it easy to look at any descrepencies. |
What
Update hypb:in-string-p tests.
Why
Create usable tests while working on fixing different edge cases.