🐛 Fix #inspect output when SSLSocket#connect fails - #764
Merged
Conversation
This identified a minor `#inspect` bug when TLS fails to connect (or after the connection has disconnected).
The TLS socket's session is not necessarily `nil` in this scenario. Since `connect` failed, `#inspect` should report "NOT ESTABLISHED".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because this relied on checking for the presence of
SSLSocket#session,#inspectwould return"TLS (NOT VERIFIED)"(which is technically correct) when"TLS (NOT ESTABLISHED)"was expected.This updates the tests to check the inspect output more thoroughly, and uses a simple boolean ivar to track when
ssl_socket_connectsucceeds.