feat: let an app skip vaults entirely instead of using an empty one - #160
Merged
Conversation
This reverts commit 04b33ff.
An empty vault (env: {}) has nothing to encrypt and gains nothing over
just not attaching one - env_refs on a target's app entry is now
optional, and deploy.py skips vault download/decryption for it.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
env:optional) — an empty vault has nothing to encrypt and gains nothing over not attaching one at all.apps.<name>.env_refsin a target manifest is now optional. When omitted (or empty),deploy/deploy.pyskips vault download/decryption for that app entirely — it still getsAPP_NAME/DATA_DIRin its.env, nothing else.beszel(zero vault-sourced env) as the example.Test plan
python3 -m unittest discover -s deploy/tests— 52 tests pass, including a newtest_app_without_env_refs_gets_no_vault_decrypted.github/actions/encrypt-envtests pass with the revert (vault manifestenv:non-empty requirement restored)