This repository was archived by the owner on Oct 22, 2026. It is now read-only.
Repository navigation
descriptor: Introduce SecretDescriptor for context-free secret descriptor parsing - #1073
Open
7-falseparfait wants to merge 2 commits into
Open
7-falseparfait wants to merge 2 commits into
7-falseparfait wants to merge 2 commits into
Conversation
Add `SecretDescriptor` to allow parsing and working with descriptors containing secret keys (`xprv`, WIF) without requiring a `secp256k1` context during parsing.
Author
|
fixed formatting, all ci checks should be passing now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #716
currently, parsing descriptors containing secret keys such as xprv and tprv into the existing public descriptor type requires a secp256k1 signing context. the parser derives public keys and stores the corresponding secrets in a keymap.
this pr introduces secretdescriptor, a wrapper around descriptor that provides:
unit tests cover secret-key parsing, wif formatting and checksums, segwit key validation, and public-only and mixed-key conversions.