Include error causes in logs - #14749
Merged
Merged
Conversation
The `reqwest::Error` retains the request URL and any HTTP error status. The Fastly error supplies static context, and direct logging callers print the source chain without repeating those details.
The checker prints the source chain so malformed archives report the underlying I/O failure.
The connection setup includes source messages before converting PostgreSQL errors into `BadConnection` strings. Connection and configuration failures retain the details needed to diagnose them.
Turbo87
added
the
C-internal 🔧
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error logs often stopped at an outer context message, hiding the failure that caused it. This PR adjusts the code so that most of our logs now include the source chains. Formatting changes are limited to sites where the additional detail is actually useful (e.g.
lettreerrors print the source chain by default). Client-facing responses remain unchanged.