Merged
Conversation
Member
|
Thanks. :) For the test I am fine either way, so if you want to change that as well, go ahead. |
Contributor
|
📌 Commit 9949d9e has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-actions |
ghost
deleted the
min-const-generics
branch
January 17, 2021 16:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#![feature(min_const_generics)]has been stabilized, so I removed#![feature(const_generics)]and#.The test
tests/run-pass/specialization.rsalso has a#![allow(incomplete_features)]for#![feature(specialization)]. I think that can be removed and#![feature(specialization)]can be replaced with#![feature(min_specialization)], but I'm not sure whether I should do that because it's a test. Feel free to ask me to remove it if it's fine to do so.