RLS always fails `textDocument/definition`, ctrl-hover and ctrl-click no longer working

[norru]

rls-preview 0.130.5 (1c755ef 2018-10-20) rustc nightly-2018-10-28

Ctrl-click and ctrl-hover no longer work, at all. "result" is always []

LSP4E to org.eclipse.corrosion.rls:{"jsonrpc":"2.0","id":"1006","method":"textDocument/definition","params":{"textDocument":{"uri":"***/src/render.rs"},"uri":"***/src/render.rs","position":{"line":92,"character":52}}}
org.eclipse.corrosion.rls to LSP4E:{"jsonrpc":"2.0","id":1006,"result":[]}

UPDATE:

• Toolchain nightly-2018-09-20 is unaffected
• Toolchain nightly-2018-10-17 is unaffected
• Toolchain nightly-2018-10-20 is affected
• Toolchain nightly-2018-10-28 is affected
• Toolchain nightly-2018-11-14 is affected
• Toolchain nightly-2018-11-20 is in some cases affected

[norru]

Checking if this was the cause: 2aa398b

[norru]

In fact

• Toolchain nightly-2018-10-17 is not affected so the Racer upgrade might have broken textDocument/definition (at least in Eclipse)

[norru]

@mickaelistria

[dvdplm]

Is this the equivalent of "Go to definition" in vsCode? Seems completely broken on recent nightlies.

[norru]

Yes, and yes. Pretty much.

[Xanewok]

Might be fixed by rust-lang/rust#55521.

[norru]

Seems fixed in

nightly-x86_64-unknown-linux-gnu rustc 1.32.0-nightly (8b096314a 2018-11-02)

EDIT: my first test failed but after a kick of the IDE it does seem fine.
EDIT: I believe my success was spurious. Failing still in 2018-11-14

[norru]

Unfortunately due to #1107 I cannot upgrade my Nightly.

[norru]

Spoke too soon, last toolchains still having broken rls-preview 0.130.5 (1c755ef 2018-10-20)

[norru]

@Xanewok, do you need to release the fix?

$HOME/.rustup/toolchains/nightly-2018-11-14-x86_64-unknown-linux-gnu/bin/rls --version

rls-preview 0.130.5 (1c755ef 2018-10-20)