fix(hir): Use expression store of parent body if available - #23202
Conversation
rustbot
added
the
S-waiting-on-review
There was a problem hiding this comment.
The fix is correct (worth noting though that after #23196 the bug won't trigger anymore, but this change will still be correct) but can you please write a test?
|
Can't believe how I missed your message. I am writing one. Sorry for such a delay |
62377e2 to
77ed31e
Compare
|
Test added. Also fixed similar issue in |
77ed31e to
99a0e5f
Compare
This comment has been minimized.
This comment has been minimized.
0335ad3 to
95f1bdb
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
95f1bdb to
cdb9251
Compare
Sorry, I accidentally messed git stash. Fixed now |
| } | ||
|
|
||
| #[test] | ||
| fn resolve_array_type_with_anon_const_panic() { |
There was a problem hiding this comment.
This probably shouldn't be here but I don't have a better place 😢
rustbot
removed
the
S-waiting-on-review
3 participants
Closes #23192
Reason of the issue:
Unlike named constants (like const C: ...), anonymous constants (like 2 + 2 inside an array type) do not get their own independent Body. Instead, they are stored directly inside the
ExpressionStoreof their parent owner.But in
crates/hir/src/source_analyzer.rsthe code that creates theTyLoweringContexthardcodes the owner to be the generic definition of the parent instead of checking that it is currently inside the Body of parent.Fix
Simply check if the type is inside an expression scope then assigns the Body as the owner instead of the Signature.
How to test
Re-run the repro provided in issue and it passes!
Run
cargo test -p hir-tyand all 1038 passed.