Skip to content

chore: kebab-case names for binaries - #17639

Merged
flip1995 merged 4 commits into
rust-lang:masterfrom
weihanglo:kebab-case-cargo-lints
Aug 28, 2026
Merged

chore: kebab-case names for binaries#17639
flip1995 merged 4 commits into
rust-lang:masterfrom
weihanglo:kebab-case-cargo-lints

Conversation

@weihanglo

Copy link
Copy Markdown
Member

These commits follow the lint cargo::non_kebab_case_bins
https://doc.rust-lang.org/nightly/cargo/reference/lints.html#non_kebab_case_bins

The failure was found in rust-lang/rust#161789 (comment) when syncing Cargo submodule.

  • clippy_dev package.name got renamed to clippy-dev.
    • Expect no actual developer workflow changes as people usually run cargo dev via .cargo/config.toml alias.
    • ‼️ One caveat of this is that the next subtree sync need to also update the name in rust-lang/rust's Cargo.lock
  • clippy_dummy, because it is published already, rename its bin name directly as clippy. This is a dummy package so it doesn't matter that much, as we are unlikely to publish new versions.
  • Test snapshots and test binary names are also converted to dashes. They are less controversial than above as being completely internal.

changelog: none

@rustbot rustbot added the S-waiting-on-community-reviews Status: This is awaiting for positive reviews from the community before a maintainer is assigned. label Aug 27, 2026
@rustbot

rustbot commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request. A reviewer will take a look after it receives 2 community reviews.

In the meantime, we would highly appreciate if you could try to review any of PRs waiting on community reviews.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 27, 2026

@Jarcho Jarcho left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine. I don't think anything other than clippy_dev and clippy_dummy need to be binaries, but it doesn't really matter either way.

cc @flip1995 in case I'm missing something.

View changes since this review

@CommanderStorm CommanderStorm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Community review: LGTM

View changes since this review

@rustbot rustbot removed the S-waiting-on-community-reviews Status: This is awaiting for positive reviews from the community before a maintainer is assigned. label Aug 28, 2026
@rustbot

rustbot commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

r? @Jarcho

rustbot has assigned @Jarcho for the project review.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: 9 candidates
  • 9 candidates expanded to 9 candidates
  • Random selection from Jarcho, Manishearth, blyxyas, dswij, llogiq

@flip1995
flip1995 added this pull request to the merge queue Aug 28, 2026
Merged via the queue into rust-lang:master with commit b443e33 Aug 28, 2026
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 28, 2026
@weihanglo
weihanglo deleted the kebab-case-cargo-lints branch August 28, 2026 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants