Skip to content

Introduce LLM policy in PR template, book and CONTRIBUTING.md - #17641

Open
blyxyas wants to merge 4 commits into
rust-lang:masterfrom
blyxyas:impl-llm-policy
Open

Introduce LLM policy in PR template, book and CONTRIBUTING.md#17641
blyxyas wants to merge 4 commits into
rust-lang:masterfrom
blyxyas:impl-llm-policy

Conversation

@blyxyas

@blyxyas blyxyas commented Aug 27, 2026

Copy link
Copy Markdown
Member

Adopting the LLM policy from rust-lang/rust, really similar to rust-lang/cargo#17330 but Clippier

@rust-lang/clippy @rust-lang/clippy-contributors

changelog:Adopt the upstream rust-lang/rust LLM policy
r? @flip1995

@rustbot rustbot added S-waiting-on-community-reviews Status: This is awaiting for positive reviews from the community before a maintainer is assigned. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Aug 27, 2026
@rustbot

rustbot commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request. A reviewer will take a look after it receives 2 community reviews.

In the meantime, we would highly appreciate if you could try to review any of PRs waiting on community reviews.

@rustbot rustbot removed the S-waiting-on-community-reviews Status: This is awaiting for positive reviews from the community before a maintainer is assigned. label Aug 27, 2026

@flip1995 flip1995 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'd like to keep this open for 2-3 days for other team members to take a look

View changes since this review

Comment thread book/src/development/llm_usage.md Outdated
When reading the policy in the context of Clippy:

* Read `rust-lang/rust` as `rust-lang/rust-clippy`.
* Read the ratifying teams as the Clippy team.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get what this means 🤔

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It means that the Clippy team is being held as the moderators in the rust-lang/rust-clippy repo, i.e. if a team member closes a pull request or requests disclosure, it's the final word until a moderator steps in.

So, the Clippy team is the final authority in the repository (until a moderator steps in).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I guess the text is mostly alignsedwith what added to cargo days ago: rust-lang/cargo@2b25b16.

Eventually the rust-lang/rust LLM policy will become more general.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh it is already mentioned in PR description 🤦🏾‍♂️
Sorry for the noise.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ähm, can we not just add clippy to that?
It is fine to add this docs now, but would this not be much simpler/clearer than documenting this here?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah got it!

ähm, can we not just add clippy to that?

Since this is the Clippy repo and clippy establishing this policy, what else do you want to add there? 🤔

@CommanderStorm CommanderStorm Aug 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not here, but in the upstream policy. So basically inlinihg this into upstream.
Less "contradicting" docs and stuff..

Can be an followup that I can do if you prefer ^^

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd still need to have some part of the policy here, and I think it'd be pretty similar to what we have.
And also, I don't think that the policy makers are looking into expanding it, but would rather have all repos in the org manually "add themselves" (as this also gives us more control over how it applies to Clippy)

Comment thread .github/PULL_REQUEST_TEMPLATE.md Outdated
Comment thread book/src/development/basics.md Outdated
Comment thread CONTRIBUTING.md Outdated
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Aug 27, 2026
@blyxyas

blyxyas commented Aug 28, 2026

Copy link
Copy Markdown
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Aug 28, 2026
@flip1995
flip1995 requested a review from Jarcho August 28, 2026 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants