Introduce LLM policy in PR template, book and CONTRIBUTING.md - #17641
Introduce LLM policy in PR template, book and CONTRIBUTING.md#17641blyxyas wants to merge 4 commits into
Conversation
|
Thanks for the pull request. A reviewer will take a look after it receives 2 community reviews. In the meantime, we would highly appreciate if you could try to review any of PRs waiting on community reviews. |
3cf39c8 to
03173eb
Compare
| When reading the policy in the context of Clippy: | ||
|
|
||
| * Read `rust-lang/rust` as `rust-lang/rust-clippy`. | ||
| * Read the ratifying teams as the Clippy team. |
There was a problem hiding this comment.
It means that the Clippy team is being held as the moderators in the rust-lang/rust-clippy repo, i.e. if a team member closes a pull request or requests disclosure, it's the final word until a moderator steps in.
So, the Clippy team is the final authority in the repository (until a moderator steps in).
There was a problem hiding this comment.
Yeah, I guess the text is mostly alignsedwith what added to cargo days ago: rust-lang/cargo@2b25b16.
Eventually the rust-lang/rust LLM policy will become more general.
There was a problem hiding this comment.
Oh it is already mentioned in PR description 🤦🏾♂️
Sorry for the noise.
There was a problem hiding this comment.
ähm, can we not just add clippy to that?
It is fine to add this docs now, but would this not be much simpler/clearer than documenting this here?
There was a problem hiding this comment.
Ah got it!
ähm, can we not just add clippy to that?
Since this is the Clippy repo and clippy establishing this policy, what else do you want to add there? 🤔
There was a problem hiding this comment.
Not here, but in the upstream policy. So basically inlinihg this into upstream.
Less "contradicting" docs and stuff..
Can be an followup that I can do if you prefer ^^
There was a problem hiding this comment.
We'd still need to have some part of the policy here, and I think it'd be pretty similar to what we have.
And also, I don't think that the policy makers are looking into expanding it, but would rather have all repos in the org manually "add themselves" (as this also gives us more control over how it applies to Clippy)
|
@rustbot ready |
Adopting the LLM policy from
rust-lang/rust, really similar to rust-lang/cargo#17330 but Clippier@rust-lang/clippy @rust-lang/clippy-contributors
changelog:Adopt the upstream
rust-lang/rustLLM policyr? @flip1995