Improve map_unwrap_or lint to support map(f).unwrap_or_default() - #17644
Open
qdot3 wants to merge 2 commits into
Open
Improve map_unwrap_or lint to support map(f).unwrap_or_default()#17644qdot3 wants to merge 2 commits into
map_unwrap_or lint to support map(f).unwrap_or_default()#17644qdot3 wants to merge 2 commits into
Conversation
rustbot
added
the
S-waiting-on-community-reviews
Collaborator
|
Thanks for the pull request, and welcome! You should hear from one of our reviewers after this PR gets at least 2 reviews from the community. Please see the contribution instructions for more information. |
rustbot
added
the
S-waiting-on-review
|
Lintcheck changes for d475df0
This comment will be updated if you push new changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Option::map_or_default/Result::map_or_defaultwas stabilized in Rust 1.98.0, so themap_unwrap_orlint should also covermap(f).unwrap_or_default(), suggestingmap_or_default(f)instead.changelog: [
map_unwrap_or]: extend to supportmap(f).unwrap_or_default()