Repository navigation

Crater runs for 1.86 #137445

Closed

Labels

C-craterS-waiting-on-reviewT-release

Milestone

Mark-Simulacrum

opened

on Feb 22, 2025

Note: Please do not conduct triage on these runs without discussing how to do so with a release team member first. Thanks!

Mark-Simulacrum
added
T-releaseRelevant to the release subteam, which will review and decide on the PR/issue.
on Feb 22, 2025
Mark-Simulacrum
added this to the 1.86.0 milestone on Feb 22, 2025
Mark-Simulacrum commented on Feb 22, 2025
Mark-Simulacrum
on Feb 22, 2025
MemberAuthor
@craterbot run name=beta-1.86-1 start=1.85.0 end=beta-2025-02-18 mode=build-and-test cap-lints=warn p=1
craterbot commented on Feb 22, 2025
craterbot
on Feb 22, 2025
Collaborator
🚧 Experiment beta-1.86-1 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more
craterbot commented on Feb 22, 2025
craterbot
on Feb 22, 2025
Collaborator
👌 Experiment beta-1.86-1 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more
craterbot
added
S-waiting-on-craterStatus: Waiting on a crater run to be completed.
on Feb 22, 2025
Mark-Simulacrum commented on Feb 22, 2025
Mark-Simulacrum
on Feb 22, 2025
MemberAuthor
@craterbot run name=beta-1.86-rustdoc-1 start=1.85.0 end=beta-2025-02-18 mode=rustdoc cap-lints=warn p=1
Mark-Simulacrum
added
C-craterCategory: Issue / PR for tracking crater runs
and removed
S-waiting-on-craterStatus: Waiting on a crater run to be completed.
on Feb 22, 2025
craterbot commented on Feb 22, 2025
craterbot
on Feb 22, 2025
Collaborator
👌 Experiment beta-1.86-rustdoc-1 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more
craterbot
added
S-waiting-on-craterStatus: Waiting on a crater run to be completed.
on Feb 22, 2025
rustbot
added
needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
on Feb 22, 2025
Urgau
removed
needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
on Feb 22, 2025
craterbot commented on Feb 24, 2025
craterbot
on Feb 24, 2025
Collaborator
🚧 Experiment beta-1.86-rustdoc-1 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more
craterbot commented on Feb 24, 2025
craterbot
on Feb 24, 2025
Collaborator
🎉 Experiment beta-1.86-1 is completed!
📊 6389 regressed and 139 fixed (587195 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more
13 remaining items
craterbot
added
S-waiting-on-craterStatus: Waiting on a crater run to be completed.
and removed
S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.
on Mar 1, 2025
craterbot commented on Mar 2, 2025
craterbot
on Mar 2, 2025
Collaborator
🚧 Experiment beta-1.86-3 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more
craterbot commented on Mar 2, 2025
craterbot
on Mar 2, 2025
Collaborator
🎉 Experiment beta-1.86-3 is completed!
📊 6186 regressed and 2 fixed (6463 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more
craterbot
added
S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.
and removed
S-waiting-on-craterStatus: Waiting on a crater run to be completed.
on Mar 2, 2025
Mark-Simulacrum
added sub-issues on Mar 2, 2025
Mark-Simulacrum commented on Mar 2, 2025
Mark-Simulacrum
on Mar 2, 2025
MemberAuthor

custom inner attributes no longer accepted (fully de-stabilize all custom inner attributes #134276)

linkage issue (maybe) regression: duplicate symbol definition #137891

RustcDecodable/Encodable removal affects lots of crates (probably most of the regressions come from that)

null pointer deref checks (already relnotes tracked in Tracking issue for release notes of #134424: Insert null checks for pointer dereferences when debug assertions are enabled #136295)

regression: ICE in rustc_codegen_ssa/src/mir/rvalue.rs:104:55: #137892

regression: literal out of range #137893
Skgland commented on Mar 3, 2025
Skgland
on Mar 3, 2025
Contributor

RustcDecodable/Encodable removal affects lots of crates (probably most of the regressions come from that)

It looks to me like most of the regressions (5957 out of 6186) are wasm-bindgen with the following error:

error: older versions of the wasm-bindgen crate are incompatible with current versions of Rust; please update to wasm-bindgen v0.2.88
Mark-Simulacrum commented on Mar 11, 2025
Mark-Simulacrum
on Mar 11, 2025
MemberAuthor
Yeah, good point. That already has relnotes tracked in #135691 (comment).
Reacted by Bennet Bleßmann
Skgland commented on Mar 11, 2025
Skgland
on Mar 11, 2025
Contributor

Yeah, good point. That already has relnotes tracked in #135691 (comment).

The tracked release notes currently say to update to at least 0.2.89 while the error message in the crater run asks to update to 0.2.88. Does one have an of-by-one error or did the version change in between?
Mark-Simulacrum commented on Mar 12, 2025
Mark-Simulacrum
on Mar 12, 2025
MemberAuthor
88 appears to be yanked, so I went with 89. I could see us backporting a trivial fix to the diagnostic, I don't have time to work on that myself though.
Reacted by Bennet Bleßmann
cuviper
closed this as completed on Apr 14, 2025

to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

Labels

C-craterS-waiting-on-reviewT-release

Type

No type

Projects

No projects

Milestone

1.86.0

Relationships

None yet

Development

No branches or pull requests