No console colors on Windows 7

[jminer]

I just updated Rust at work, and now rustc has no colors in the console (Cargo still does). I'm using Windows 7 64-bit with Rust MSVC 32-bit. I tried 1.29 stable and it worked, but 1.30 stable and the latest nightly don't work. I have tried both cmd.exe and PowerShell and both look the same. This is a big regression in usability, so I'll probably downgrade back to a working version.

[ehuss]

I can confirm this happens on Windows 8, and can confirm it is caused by rust-lang/cargo#5862.
cc @kennytm, @alexcrichton

[kennytm]

Will cargo run --color=always enable the colors?

[ehuss]

--color=always does not seem to have an effect. It is passing --color=always to rustc, but for some reason rustc is not returning content with ANSI codes. If you run rustc manually on the command line, the colors seem to work.

[alexcrichton]

Thanks for the report @jminer! I think this'll get fixed by #55788

@kennytm I think we only tested msys shells earlier, right? I think we're hitting this branch of termcolor which I guess means that this is succeeding somehow. It's not entirely clear to me why that's all somehow not failing but I'm pretty sure that asking for AlwaysAnsi will do the trick

[kennytm]

@alexcrichton previously i did have tested on cmd.exe, but i haven't followed the recent changes which might have broken it

[alexcrichton]

Hm ok, that's worrisome! If #55788 doesn't do the trick I can try to investigate later, but it'll be quite awhile before I have a windows computer to test on again

[alexcrichton]

For posterity there was some discussion of why this isn't actually fixed on nightly right now, and @kennytm has a PR to termcolor which should fix this

[MSxDOS]

Any chance this is getting fixed in the nearest future?

[mati865]

@MSxDOS I pinged termcolor author and he is reviewing PR mentioned above so this should get fixed on nightly soon.