: token not accepted in attribute?

[Mark-Simulacrum]

https://crater-reports.s3.amazonaws.com/beta-1.39-1/beta-2019-09-28/reg/jellyschema-0.11.10/log.txt

I can't seem to reproduce this in a trivial example so it might be related to pre-cfg expansion or something like that...

cc #64962

[petrochenkov]

Most likely introduced by #64462.

[petrochenkov]

Minimized:

macro_rules! m { () => () }

#[allow(clippy:all)]
m!();

fn main() {}

Inert attributes on macro invocations (like allow in this case) disappear during macro expansion.

Previously such attributes were partially checked (compared to inert attributes remaining in the AST), after #64462 they are fully checked (in the same way as inert attributes remaining in the AST).
It may make sense to not check them at all (cc #63221).

[estebank]

It sounds like we would want to warn on these cases.

[Centril]

It may make sense to not check them at all (cc #63221).

Imo, based on a single regression, which also exposed a bug in the crate, it doesn't seem like a justified change.

[estebank]

I hadn't checked how many dependencies it had. It should be fine but we must proactively reach out to fix their crate.

[Centril]

Done in balena-io-modules/jellyschema#118.