Checked/wrapping/unbounded funnel shifts - #161119
Conversation
rustbot
added
S-waiting-on-review
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use Why was this reviewer chosen?The reviewer was selected based on:
|
tgross35
added
the
S-waiting-on-ACP
|
ACP at rust-lang/libs-team#855 |
| /// This function will return `None` if `n` is greater than or equal to the number of | ||
| /// bits in `self`, i.e. when [`funnel_shl`](Self::funnel_shl) would panic. | ||
| #[rustc_const_unstable(feature = "wrapping_funnel_shifts", issue = "none")] | ||
| #[unstable(feature = "wrapping_funnel_shifts", issue = "none")] |
There was a problem hiding this comment.
Please create a new tracking issue. I think it's fine to do even before the ACP is accepted
There was a problem hiding this comment.
We will update this PR when we are next back at our computer on Monday for other reasons anyway (adding strict versions, adding tests), so we will make a tracking issue and list it then too.
|
☔ The latest upstream changes (presumably #161719) made this pull request unmergeable. Please resolve the merge conflicts by rebasing. |
4 participants
This implements the wrapping funnel shifts requested at rust-lang/libs-team#642 (comment) and also some additional forms of funnel shift proposed at rust-lang/libs-team#855; this might interact with #161015, which is attempting to stabilize the original funnel shift methods.
The work in this PR was done entirely by some people inside a human brain, without the use of any LLMs…or much use of an IDE since ours kept crashing during this process and we had to resort to a plain text editor. 😅