Rollup of 7 pull requests - #162592
Merged
Merged
Conversation
…dering object bounds
This makes their test environment consistent between runs inside the cg_clif and rust repos.
A fatal error that doesn't actually abort is indistinguishable from a regular error. And the only places where emit_almost_fatal is called, the produced FatalError is ignored.
The explanation provided was wrong. Libc doesn't exist on Windows, so naturally this failed on missing lib. I have no idea what shenanigans link.exe does to make this pass, but surely it doesn't actually link libc.
This avoids a delayed bug if compilation is aborted between checking function ABIs and codegening all functions.
And remove the encoded metadata if there are any errors or delayed bugs after encoding.
* fix(traits): Remove expression references from index suggestions * Use expression spans for index reference removal suggestions * refactor(trait-selection): Simplify dereference suggestion guard
re-equate the object bound's trait ref with the goal's when considering object bounds rust-lang/trait-system-refactor-initiative#295 bisects to rust-lang#152859, which changed `probe_and_consider_object_bound_candidate` to pass the trait object's trait ref in a binder to `predicates_for_object_candidate`, which calls `instantiate_binder_with_infer` on the binder. Re-instantiating the binder like this, however, loses the constraint that `'x: 'static`, even though earlier in `match_assumption` we actually did equate the object trait ref with the goal's trait ref, which gave us the `eq('x, 'static)` relationship we needed. However, the new inference var has no relationship with the equality we established; hence we lose `'x: 'static` and therefore `Self: 'static` and `'s: 'static`. We therefore inline `match_assumption` and directly equate the assumption's trait ref with the goal's before passing the assumption to `predicates_for_object_candidate` instead and remove the re-instantiation. fixes rust-lang/trait-system-refactor-initiative#295 cc @lcnr
Some cleanups around fatal errors and delayed bugs With the aim of making it easier to move some compiler passes to different locations. And in particular to allow moving them across `has_errors_or_delayed_bugs` calls. This is a prerequisite for a local change that improves the effectiveness of cargo build pipelining. Fixes rust-lang#152204
…ng_index, r=jieyouxu fix(traits): Remove expression references from index suggestions Fix issue: rust-lang#162419
… r=oli-obk Fix run-make/prune-link-args to work with MinGW The explanation provided was wrong. Libc doesn't exist on Windows, so naturally this failed on missing lib. I have no idea what shenanigans link.exe does to make this pass, but surely it doesn't actually link libc.
…ieyouxu,Kobzol Attemped fix for home dir problem on `dist-aarch64-llvm-mingw` This is a fix for this spurious failure, which seems to regularly happen lately rust-lang#162550 (comment) disclaimer: I have no clue what is causing this and that I'm just attacking the symptoms. Seems like some kind of github runner misconfiguration? The PR is being discussed here: [#t-infra > Tree ops @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Tree.20ops/near/622969695)
…=Darksonn doc: Fix external mention of signum() return value regarding NaNs `is_sign_positive()`/`is_sign_negative()` documentation refer to using `signum() ` but misrepresent the return value of the latter; `signum()` returns a float so it cannot be `false`; `signum()` documentation documents it as returning a NaN in this case, so propagated that to these references.
rustbot
added
A-CI
rustbot
added
the
WG-trait-system-refactor
Member
Author
|
@bors r+ p=5 |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
Member
Author
|
@bors treeopen |
Contributor
|
Tree is now open for merging. |
rust-bors
Bot
added
merged-by-bors
Contributor
This was referenced Sep 10, 2026
Contributor
|
📌 Perf builds for each rolled up PR:
parent commit: c4c4a57693 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing c4c4a57 (parent) -> 018018e (this PR) Test differencesShow 39 test diffsStage 1
Stage 2
Additionally, 21 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 018018e881e2db0956f229dbb543e21f058d1ce7 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (018018e): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (primary -0.8%, secondary -3.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -0.1%, secondary 3.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 480.118s -> 479.823s (-0.06%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
dist-aarch64-llvm-mingw#162554 (Attemped fix for home dir problem ondist-aarch64-llvm-mingw)r? @ghost
Create a similar rollup