Skip to content
Navigation Menu
Sign in
Appearance settings
Platform
AI CODE CREATION
GitHub Copilot
Write better code with AI
GitHub Copilot app
Direct agents from issue to merge
MCP Registry
Integrate external tools
DEVELOPER WORKFLOWS
Actions
Automate any workflow
Codespaces
Instant dev environments
Issues
Plan and track work
Code Review
Manage code changes
Code Quality
Enforce quality at merge
APPLICATION SECURITY
GitHub Advanced Security
Find and fix vulnerabilities
Code security
Secure your code as you build
Secret protection
Stop leaks before they start
EXPLORE
Why GitHub
Documentation
Blog
Changelog
Marketplace
View all features
Solutions
BY COMPANY SIZE
Enterprises
Small and medium teams
Startups
Nonprofits
BY USE CASE
App Modernization
DevSecOps
DevOps
CI/CD
View all use cases
BY INDUSTRY
Healthcare
Financial services
Manufacturing
Government
View all industries
View all solutions
Resources
EXPLORE BY TOPIC
AI
Software Development
DevOps
Security
View all topics
EXPLORE BY TYPE
Customer stories
Events & webinars
Ebooks & reports
Business insights
GitHub Skills
SUPPORT & SERVICES
Documentation
Customer support
Community forum
Trust center
Partners
View all resources
Open Source
COMMUNITY
GitHub Sponsors
Fund open source developers
PROGRAMS
Security Lab
Maintainer Community
GitHub Stars
Archive Program
REPOSITORIES
Topics
Trending
Collections
Enterprise
ENTERPRISE SOLUTIONS
Enterprise platform
AI-powered developer platform
AVAILABLE ADD-ONS
GitHub Advanced Security
Enterprise-grade security features
Copilot for Business
Enterprise-grade AI features
Premium Support
Enterprise-grade 24/7 support
Pricing
Search
/
Sign in
Sign up
Appearance settings
You signed in with another tab or window.
Reload
to refresh your session.
You signed out in another tab or window.
Reload
to refresh your session.
You switched accounts on another tab or window.
Reload
to refresh your session.
Dismiss alert
{{ message }}
Uh oh!
There was an error while loading.
Please reload this page
.
rust-lang
/
rust
Public
Uh oh!
There was an error while loading.
Please reload this page
.
Notifications
You must be signed in to change notification settings
Fork
15.8k
Star
119k
Code
Issues
5k+
Pull requests
1.4k
Actions
Projects
Security and quality
6
Insights
Additional navigation options
Code
Issues
Pull requests
Actions
Projects
Security and quality
Insights
Deduplicate pretty printing of constants
- #67133
#67133
Merged
bors
merged 18 commits into
rust-lang:master
rust-lang/rust:master
from
oli-obk:it_must_be_a_sign
oli-obk/rust:it_must_be_a_sign
Copy head branch name to clipboard
Mar 16, 2020
Conversation
Commits
18
(18)
Checks
Files changed
Merged
Deduplicate pretty printing of constants
#67133
bors
merged 18 commits into
rust-lang:master
rust-lang/rust:master
from
oli-obk:it_must_be_a_sign
oli-obk/rust:it_must_be_a_sign
Copy head branch name to clipboard
Commits
Commits on Mar 11, 2020
Deduplicate and clean up pretty printing logic
oli-obk
committed
02dbb35
View commit details
Copy full SHA for 02dbb35
Browse repository at this point
Address review comments around `type_ascribed_value`
oli-obk
committed
02f4eeb
View commit details
Copy full SHA for 02f4eeb
Browse repository at this point
Print braces only in print_ty mode
oli-obk
committed
3b82edd
View commit details
Copy full SHA for 3b82edd
Browse repository at this point
Eliminate all ParamEnv::empty uses in pretty printing
oli-obk
committed
4ddb4bd
View commit details
Copy full SHA for 4ddb4bd
Browse repository at this point
Don't print leading zeros on hex dumps constants
oli-obk
committed
e22ddfd
View commit details
Copy full SHA for e22ddfd
Browse repository at this point
Reduce special casing in the const pretty printer
oli-obk
committed
b837e71
View commit details
Copy full SHA for b837e71
Browse repository at this point
Print leading zeros for non pointers
oli-obk
committed
b2e93a4
View commit details
Copy full SHA for b2e93a4
Browse repository at this point
Prefer fall through to code repetition
oli-obk
committed
1191eb4
View commit details
Copy full SHA for 1191eb4
Browse repository at this point
Don't print all zsts as their type as it makes no sense for more complex examples (e.g. structs)
oli-obk
committed
154f3f1
View commit details
Copy full SHA for 154f3f1
Browse repository at this point
Reuse type ascripted printing for type cast printing
oli-obk
committed
b78dbf4
View commit details
Copy full SHA for b78dbf4
Browse repository at this point
Print function pointer type for function pointer const generics
oli-obk
committed
fff2e0f
View commit details
Copy full SHA for fff2e0f
Browse repository at this point
Don't print literal type suffixes if `print_ty` is false
oli-obk
committed
cc9ca64
View commit details
Copy full SHA for cc9ca64
Browse repository at this point
Generalize typed value printing and use for undef printing
oli-obk
committed
2e91065
View commit details
Copy full SHA for 2e91065
Browse repository at this point
Address review comments
oli-obk
committed
db9ddf1
View commit details
Copy full SHA for db9ddf1
Browse repository at this point
Commits on Mar 12, 2020
Comment nit
oli-obk
committed
d0b1211
View commit details
Copy full SHA for d0b1211
Browse repository at this point
Remove fn special casing in const printing
oli-obk
committed
6e73a14
View commit details
Copy full SHA for 6e73a14
Browse repository at this point
Commits on Mar 13, 2020
Print ConstKind::Bound the same as TyKind::Bound
oli-obk
committed
306df94
View commit details
Copy full SHA for 306df94
Browse repository at this point
Print ConstKind::Placeholder just like TyKind::Placeholder
oli-obk
committed
6ca65bd
View commit details
Copy full SHA for 6ca65bd
Browse repository at this point
You can’t perform that action at this time.