Modernize GitHub Actions workflows - #151
Open
tisonkun wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
I'm reviewing the output and would mark it as ready for review when I'm OK with the PR. |
…hub-actions # Conflicts: # .github/workflows/test.yml
nagisa
reviewed
Aug 2, 2026
Contributor
Author
|
@nagisa Thanks for your review! I'll handle this PR today or tomorrow. It is now purely AI generated but I'd pefer to create a draft PR for better human review (by myself) experience. This should be what a draft PR designed for, though. |
Member
|
sure, doesn't hurt to give it a quick look and adjust the direction early on though ^^ |
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
marked this pull request as ready for review
August 2, 2026 20:16
Contributor
Author
|
@nagisa This PR should be now reviewable. |
Contributor
Author
|
I checked the AI generated patch and addressed the comments. Briefly, it
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #147.
Summary
actions/checkoutfrom v4 to v7 andactions/cachefrom v4 to v6actions-rs/toolchainandactions-rs/cargoactions withdtolnay/rust-toolchainand direct Cargo/Cross commandsmingw-w64-i686-clangpackageFailure analysis
Both failures in run 30741090730 stop in
msys2/setup-msys2witherror: target not found: mingw-w64-i686-clang. MSYS2 phased out its 32-bit environments and removed CLANG32, so the oldC:/msys64/mingw32/bin/clang-cl.exesetup is no longer maintainable.The replacement uses
C:/Program Files/LLVM/bin/clang-cl.exe, which is provided by the GitHub-hosted Windows image and supports both MSVC targets. Windows GNU jobs now install the target-specific Rust host toolchain, including the officialrust-mingwcomponent, instead of relying on legacy MSYS2 environments.Validation
go run github.com/rhysd/actionlint/cmd/actionlint@v1.7.12 -color .github/workflows/test.ymlcargo test --all-targetscargo test --manifest-path psm/Cargo.toml --all-targetsgit diff --check