Port stdarch-gen-arm to stdarch-gen-common - #2200
Open
xonx4l wants to merge 1 commit into
Open
Conversation
Kobzol
reviewed
Aug 4, 2026
| STDARCH_GEN_MODE: check | ||
| run: | | ||
| cargo run --bin=stdarch-gen-arm --release -- crates/stdarch-gen-arm/spec | ||
| git diff --exit-code |
Member
There was a problem hiding this comment.
The git diff command shouldn't be needed anymore with STDARCH_GEN_MODE: check, right?
| .ok() | ||
| .flatten() | ||
| .filter(|f| f.exists()) | ||
| .expect("could not locate crates/core_arch/src; pass OUTPUT_DIR explicitly") |
Member
There was a problem hiding this comment.
Suggested change
| .expect("could not locate crates/core_arch/src; pass OUTPUT_DIR explicitly") | |
| .expect("could not locate crates/core_arch/src; pass OUTPUT_DIR command-line argument explicitly") |
Otherwise it might look like it's an environment variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR Port's stdarch-gen-arm to stdarch-gen-common harness .
Since
run_generatoroperates on a single folder butstdarch-gen-armoutputs to manycore_arch/src/<arch>/<feature>/folders main now callsrun_generatoronce per spec filepassing that spec's output folder as the directory to check/bless.
Dropped the old stdout fallback as the harness now always writes to a real folder.
r? @folkertdev