Skip to content

core_arch: Remove redundant LoongArch64 SIMD tests - #2227

Closed
heiher wants to merge 1 commit into
rust-lang:mainfrom
heiher:loong64-remove-redundant-tests
Closed

heiher wants to merge 1 commit into
rust-lang:mainfrom
heiher:loong64-remove-redundant-tests

Conversation

@heiher

@heiher heiher commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Remove redundant LoongArch64 SIMD intrinsic tests from core_arch, as they are covered by intrinsic-test.

@rustbot

rustbot commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

r? @folkertdev

rustbot has assigned @folkertdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @Amanieu, @adamgemmell, @davidtwco, @folkertdev, @sayantn
  • @Amanieu, @adamgemmell, @davidtwco, @folkertdev, @sayantn expanded to Amanieu, adamgemmell, davidtwco, folkertdev, sayantn
  • Random selection from Amanieu, adamgemmell, davidtwco, folkertdev, sayantn

@heiher

heiher commented Sep 15, 2026

Copy link
Copy Markdown
Contributor Author

Depends on #2226

@folkertdev

Copy link
Copy Markdown
Contributor

For x86_64 we've mostly kept these tests, they are faster to run and deterministic. We can drop tests if really all they check is that the intrinsic is hooked up I guess.

But also the intrinsic tests do some filtering (e.g. skip anything with an argument that is a pointer), so they don't test everything.

@heiher

heiher commented Sep 17, 2026

Copy link
Copy Markdown
Contributor Author

Thanks! Let's keep these tests.

@heiher heiher closed this Sep 17, 2026
@heiher
heiher deleted the loong64-remove-redundant-tests branch September 18, 2026 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants