Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
目的
#3 での大幅なリファクタリングにより、かなりコードベースの探索が行いやすくなっている。
ReactではアニメーションなどはCSSとJS自体に依存しておりそれ自体がなにを行っているかをコードから読み取ることは比較的簡単である。
しかし、AGSにおいて要素移動などはGTKに委任しておりこれの操作が必要となっている。
この部分のコードについてどのような思想・考えでそのコードが採択されたかを読み解くのは非常に難解である。
そのため、その部分へのコメントと共に実装の意図を見えやすくするリファクタリングを行う。
Roadmap