Conversation
/recipes の loader で一覧の最初のページを先に取る。画面の描画はこれまで どおり session の確定を待つ。API は requireAuth で自ら session を確かめる ので、未ログインなら 401 が返るだけで画面には出ない。 - 一覧の取得設定を recipeListQueryOptions にまとめ、画面と loader で共有する - router の context で queryClient を渡し、router は main.tsx で作る - URL にタグの指定があるときは先に取らない（消えたタグの id を外してから取るため） - 先に取るときは 401 を再試行しない Refs #202
起動時の一覧は常に絞り込みなしで、絞り込んだ一覧は画面が自分で取るのと 同時になるので、先に取っても縮まない。条件の組み立てを loader と画面で 二重に持たないよう、先取りを絞り込みなしに限る。 Refs #202
401 は取り直しても変わらず、session の回復は viewer の経路が担う（ADR 0011）。 一覧の先取りだけに置いていた 401 の除外を、既定の再試行に移す。 Refs #202
perf(web): 起動時に一覧の取得をセッションの確認と並べて始める
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.