Improve pipeline I/O performance - #272
Open
msettles wants to merge 3 commits into
Open
Conversation
msettles
force-pushed
the
perf/benchmark-speedups
branch
from
July 1, 2026 21:48
2cd209a to
44d4bc0
Compare
joe-angell
approved these changes
Jul 6, 2026
joe-angell
left a comment
Collaborator
There was a problem hiding this comment.
Very nice, I'm surprised bitkey is faster than boost dynamic bitset, but it looks good.
Member
Author
|
All of these requests were for speed improvements as my biggest issues
have been speed, full flow cells were taking a day or more to process.
I think the total speed up, was between 15-20x and I wired in a prototype
in hts_Stats for parallelism. New bottleneck seems to be decompression of a
single file.
ALL AI enhanced improvement.
On July 6, 2026 at 10:46:00 AM, Joe Angell ***@***.***) wrote:
***@***.**** approved this pull request.
Very nice, I'm surprised bitkey is faster than boost dynamic bitset, but it
looks good.
—
Reply to this email directly, view it on GitHub
<#272?email_source=notifications&email_token=AAE6RZT2HTD3ZC4HOWMHSVL5DPQVRA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINRTHAZTOMBWGE22M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#pullrequestreview-4638370615>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE6RZX42DHCOXITXBFYMRD5DPQVRAVCNFSNUABEKJSXA33TNF2G64TZHM3DGNZQGMZDCOB3JFZXG5LFHM2DOOBYGAZDSMBUGKQXMAQ>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/AAE6RZWJPXFVTSKP6M6ZOOL5DPQVRA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINRTHAZTOMBWGE22M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/AAE6RZVUCHA5SEHPMCVQMDT5DPQVRA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINRTHAZTOMBWGE22M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-t stdoutcompression-leveloption and make JSON fixture comparisons key-order stableBenchmarks
Sample:
/Users/biomsettles/projects/Archive/Alliance_MiSeq_Bacterial_Data/00-Original/sample1with 805,327 paired fragments.hts_LengthFilter: 65.40shts_LengthFilter: 18.22s--compression-level 1and default pigz threads: 16.89s, 338M output-u: 16.83s, 1.0G outputHTSTREAM_PIGZ_THREADS=2: 17.03s;HTSTREAM_PIGZ_THREADS=4: 16.97s, effectively flat on this sampleValidation
cmake --build build -j8ctest --test-dir build --output-on-failure(13/13 passed)cd regression && ./regression.sh ../build test--compression-level 10is rejectedgzip -tpassed for benchmark compressed output