feat(release): send the Deployment Protection bypass header in live parity checks - #26
Merged
Merged
Conversation
…arity checks Protected preview URLs answer with a 302 to Vercel SSO, which the parity check reports as a bare redirect. Send VERCEL_AUTOMATION_BYPASS_SECRET as x-vercel-protection-bypass when the environment carries it, name the variable in the failure when the redirect is Vercel SSO, and document the step in RELEASE.md.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deployment Protection bypass for live parity
RELEASE.md step 8 asks for a preview-first parity check, but Deployment Protection answers every generated
*.vercel.appURL with a 302 to Vercel SSO, and the check reported that as a bare redirect. Nothing about the build was wrong; the check could not read the deployment.scripts/check-live-parity.ts: whenVERCEL_AUTOMATION_BYPASS_SECRETis set, send it asx-vercel-protection-bypass. When a redirect targets Vercel SSO, the failure names the variable and where the value comes from.scripts/check-live-parity.test.ts: the header is sent only when the environment carries a secret, and the SSO redirect message names the fix.RELEASE.md: one paragraph under step 8. The public aliases in step 9 are unprotected and need no secret.Verified locally: typecheck, 209 unit tests, guard scan clean. Against a protected preview the check now fails with the new message; the bypass path itself needs the project secret, which the operator holds.