Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A redirect can move to a different resource with the same ETag or Last-Modified value. Its 304 response must not reuse the previous target's body. Clear the stale validators and refetch within the original deadline.
The regression covers both validators,
retries=0, the new body/URL and the next cache hit. It fails before the fix.Validation: Linux x86_64, Rust 1.100.0; offline loopback tests with proxy environment variables omitted.
cargo test --locked --all-targets: 1,138 passed, 4 existing tests ignored.cargo clippy --locked --all-targets -- -D warnings: passed.cargo fmt --all --check: blocked by existing main formatting failures; this patch adds none.AI assistance: implementation, tests and independent agent review.