Skip to content

fix(results): preserve metadata and sources when merging transfers - #147

Open
TKY-27 wants to merge 1 commit into
sahenjp:mainfrom
TKY-27:fix/transfer-source-integrity
Open

TKY-27 wants to merge 1 commit into
sahenjp:mainfrom
TKY-27:fix/transfer-source-integrity

Conversation

@TKY-27

@TKY-27 TKY-27 commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

Promoting a higher-scored transfer replaced its URL but retained another page's metadata and lost the former representative's URL. Select the whole representative before combining engines, positions and source history.

Regressions cover both input orders, repeated promotions and the existing first-wins tie rule. The two new tests fail before the fix.

Validation: Linux x86_64, Rust 1.100.0; offline loopback tests with proxy environment variables omitted.

  • cargo test --locked --all-targets: 1,139 passed, 4 existing tests ignored.
  • cargo clippy --locked --all-targets -- -D warnings: passed.
  • cargo fmt --all --check: blocked by existing main formatting failures; this patch adds none.

AI assistance: implementation, tests and independent agent review.

@TKY-27
TKY-27 requested a review from sahenjp as a code owner November 15, 2026 22:18
Copilot AI balanced review requested due to automatic review settings November 15, 2026 22:18

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants