Note that the benchmark table is a sample, not a fixed result - #7
Merged
Merged
Conversation
Re-running it on the same machine moves the speedups by tens of percent, so presenting them without that caveat invites a reader to treat a sample as a guarantee. The row-group counts are stable and are the number actually worth reading.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A clean-clone verification run produced 172.7x on the selective range where the README records 154.6x — same code, same data, same machine. Both are honest samples of the same measurement, but presenting one without saying so invites a reader to treat it as a guarantee and then wonder what they did wrong.
The row-group counts (3 read, 59 pruned) are stable, because they are a property of the data and the predicate rather than of the hardware — so the README now points at those as the number worth reading.