Skip to content

fix(W-23983692): migrate to eslint flat config and typescript 6 and bump plugin packages - #2917

Closed
k80bowman wants to merge 2 commits into
mainfrom
k80/ts-v6
Closed

fix(W-23983692): migrate to eslint flat config and typescript 6 and bump plugin packages#2917
k80bowman wants to merge 2 commits into
mainfrom
k80/ts-v6

Conversation

@k80bowman

Copy link
Copy Markdown
Contributor

What does this PR do?

Migrates the CLI's dev toolchain to the latest major versions and modernizes the lint setup:

  1. Replaces the legacy .eslintrc.cjs files with an ESLint 10 flat config (eslint.config.mjs), removing .eslintignore, root .eslintrc.cjs, and test/.eslintrc.cjs.
  2. Bumps @salesforce/dev-scripts to v14, eslint to v10, typescript to v6, and @salesforce/ts-types to ^3.2.0.
  3. Adds explicit @types/* devDeps (chai, mocha, node, sinon) and mocha types in tsconfig.json/test/tsconfig.json now required by the toolchain, plus a rootDir and the **/eslint.config.* glob to the wireit lint inputs.

Also bumps @salesforce/core, the bundled @salesforce/plugin-* packages, and the @oclif/plugin-plugins/@oclif/plugin-version dependencies to their latest versions.

The only source change is in src/flags.ts, applying the ??= idiom now enforced by the updated lint config.

Acceptance Criteria

  • yarn build, yarn lint, and yarn test pass under TypeScript 6, ESLint 10 flat config, and dev-scripts 14.
  • No behavior change to the shipped CLI beyond the bundled plugin/core version bumps.

Testing Notes

Covered by the existing automated build/lint/test suite. Verify locally with a clean install:

  1. yarn install
  2. yarn build
  3. yarn lint — confirm the flat config is picked up and there are no errors.
  4. yarn test

No manual CLI testing applicable — there are no command, flag, or output changes.

Checklist

  • This change has been approved by the CLI Review Board or approval isn't required. Anything that adds/changes/deletes commands, flags, output, or json output has to be reviewed.
  • Does this follow the deprecation policy?

What issues does this PR fix or reference?

@W-23983692@

Replace .eslintrc.cjs with eslint.config.mjs, bump to
dev-scripts 14, eslint 10, and typescript 6. Add explicit
@types/* devDeps and mocha types now required by the toolchain.
@k80bowman

Copy link
Copy Markdown
Contributor Author

Closing in favor of #2918

@k80bowman k80bowman closed this Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants