Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for online help media and enhances permission and settings management in the app. The main changes include adding a repository for fetching and caching online help media, updating the build configuration and dependencies for media playback, expanding the app’s permission model, and improving settings for secure and online features.
Online Help Media Support:
HelpMediaRepositoryto fetch and cache online help media mappings from a remote source, with local caching and fallback mechanisms.app/build.gradle.ktsto includeandroidx.media3.uifor media playback in online help.KEY_ONLINE_HELP_MEDIA) and corresponding getter/setter inSettingsRepositoryto enable or disable online help media. [1] [2]Permission Model Improvements:
AppPermissionenum, associating permission keys with localized titles, icons, and aliases for improved permission handling and display.PermissionRegistryto support registration and lookup byAppPermissionobjects, including alias resolution. [1] [2]Settings and Feature Registry Updates:
KEY_SECURE_SENSITIVE_TILES) inSettingsRepository, with corresponding UI toggle support. [1] [2]FeatureRegistryto explicitly sethasMoreSettingsfor several network features and to add a searchable setting for secure sensitive tiles. [1] [2] [3] [4] [5]Build and Versioning:
18.0-beta.2inapp/build.gradle.kts.These changes collectively improve the app’s flexibility in handling permissions, user settings, and in providing rich, up-to-date online help content.