Skip to content

Develop - swap config icons, auto dismiss permissions sheet on granting - #943

Merged
sameerasw merged 3 commits into
mainfrom
develop
Sep 9, 2026
Merged

Develop - swap config icons, auto dismiss permissions sheet on granting#943
sameerasw merged 3 commits into
mainfrom
develop

Conversation

@sameerasw

Copy link
Copy Markdown
Owner

This pull request introduces a small UI fix and a functional improvement to the permissions sheet. The most notable change is the automatic dismissal of the permissions bottom sheet when all permissions are granted, improving user experience. There are also minor corrections to icon usage in the settings screen.

Permissions sheet behavior:

  • The PermissionsBottomSheet now automatically dismisses itself by calling onDismissRequest() when all permissions have been granted, using a LaunchedEffect to observe the state.

Settings screen icon corrections:

  • Swapped the icons in the settings screen so that the correct icon is displayed for each button: the leading button now uses rounded_vertical_align_top_24 and the trailing button uses rounded_vertical_align_bottom_24, correcting a previous mismatch. [1] [2]

Imports:

  • Added the missing import for LaunchedEffect in PermissionsBottomSheet.kt to support the new functionality.

@sameerasw sameerasw self-assigned this Sep 9, 2026
@sameerasw sameerasw added bug Something isn't working enhancement New feature or request labels Sep 9, 2026
@sameerasw
sameerasw merged commit 4606e52 into main Sep 9, 2026
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Essentials Progress Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant