compute: normalize cross-HV BDM device names - #653
Open
anokfireball wants to merge 1 commit into
Open
Conversation
Customers can set their own BDM device paths. VMware does not pass these paths to the guest as disk targets. It uses them to keep a stable volume attachment order, while the guest still sees normal SCSI devices and /dev/sdX device names in guest. This is not compatible with the current libvirt/KVM path. Nova passes the BDM device name to libvirt as the disk target, and libvirt expects a guest disk target name for the selected bus. During VMware-to-KVM resize, journal the original root and BDM names. Then assign /dev/vdX target device names following the VMware order: root first, then remaining volumes by original device name. On revert, restore the journaled root name, BDM names, and disk buses exactly. Change-Id: Id130a3ef18be29bfb8bab3681c75554b23862ba5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customers can set their own BDM device paths. VMware does not pass these paths to the guest as disk targets. It uses them to keep a stable volume attachment order, while the guest still sees normal SCSI devices and /dev/sdX device names in guest.
This is not compatible with the current libvirt/KVM path. Nova passes the BDM device name to libvirt as the disk target, and libvirt expects a guest disk target name for the selected bus.
During VMware-to-KVM resize, journal the original root and BDM names. Then assign /dev/vdX target device names following the VMware order: root first, then remaining volumes by original device name.
On revert, restore the journaled root name, BDM names, and disk buses exactly.
Change-Id: Id130a3ef18be29bfb8bab3681c75554b23862ba5