Skip to content

fix: read APP_ID from org secrets instead of repo vars - #441

Merged
allanbowe merged 2 commits into
mainfrom
fix-app-token-secret-ref
Aug 24, 2026
Merged

fix: read APP_ID from org secrets instead of repo vars#441
allanbowe merged 2 commits into
mainfrom
fix-app-token-secret-ref

Conversation

@sasjs-dev

@sasjs-dev sasjs-dev Bot commented Aug 24, 2026

Copy link
Copy Markdown

Problem

The last two publish runs on main failed at the docs-site steps:

Root cause

The workflow referenced vars.APP_ID (a repository/org variable), but APP_ID was created as an organisation secret ~2 months ago. vars.APP_ID therefore resolved to an empty string and the action aborted before reading the private key.

Fix

  • Point app-id at secrets.APP_ID
  • Gate the token-generation step on new_release_published == 'true' so docs-site config problems cannot fail publish runs that produce no release
  • Add a temporary debug step printing input lengths only (never values — secrets are masked anyway) to confirm both org secrets are visible to this repo; remove after one green run

Note: the npm release itself is unaffected — v5.2.0 published successfully; only the docs-site publish chain was broken.

sasjs-dev and others added 2 commits August 24, 2026 14:04
The Generate GitHub App token step failed with
'[@octokit/auth-app] appId option is required' because it referenced
vars.APP_ID, but APP_ID was created as an organisation secret two
months ago, not a repository variable. Point app-id at secrets.APP_ID.

Also gate the token-generation and debug steps on
new_release_published so docs-site config issues cannot fail a
publish run that produced no release, and add a temporary debug step
printing input lengths (never values) to confirm secret visibility.
@allanbowe
allanbowe merged commit 4fda20d into main Aug 24, 2026
3 checks passed
@allanbowe
allanbowe deleted the fix-app-token-secret-ref branch August 24, 2026 13:14
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 5.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant