fix(auth): remove unnecessary opaque-token debug message - #264
Merged
Conversation
The 'isTokenExpiring: token is not a decodable JWT' debug message was still surfacing in CLI output because process.logger is not configured in the CLI context, and the misleading optional-chain fallback can route to console.debug regardless. Opaque tokens are the norm for SAS Logon Manager, so this is routine internal diagnostic noise, not useful to end users. Remove the debug call entirely (option 1). Also remove the now-unused process.logger type augmentation (process.d.ts) and the ts-node files:true config that PR #263 added solely to support the removed call. An opaque token still returns false (usable) and is fully silent.
![4gl-reviewer[bot]](https://avatars.githubusercontent.com/in/4587573?s=60&v=4){kind=small}
allanbowe
approved these changes
Aug 19, 2026
|
🎉 This PR is included in version 3.6.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
isTokenExpiring: token is not a decodable JWT, treating it as not expiring.message that was still printed constantly in CLI output despite PR #263.
The
process.logger?.debug?.()optional chain could still fall through toconsole.debugin contexts where no logger is wired (e.g. the CLI).Remove the debug message entirely - opaque tokens are the norm for SAS Logon Manager, so this is routine internal diagnostic noise, not useful to end users.
This also removes the now-unused
process.loggertype augmentation (src/types/system/process.d.ts) and thets-node.files:trueblock added by PR #263solely to support it.
An opaque Access/Refresh token still returns
false(usable / not expiring) and isfully silent. Test added asserting no console output for opaque tokens.