Skip to content

chore(deps): upgrade Node to 26.8.1 - #574

Merged
savvy-web-bot[bot] merged 1 commit into
mainfrom
pnpm/config-deps
Aug 28, 2026
Merged

savvy-web-bot[bot] merged 1 commit into
mainfrom
pnpm/config-deps

Conversation

@savvy-web-bot

@savvy-web-bot savvy-web-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Dependency Updates

root workspace

Dependency Type Action From To
node runtime updated 26.7.0 26.8.1

This PR was automatically created by silk-update-action

chore(deps): upgrade Node to 26.8.1

Signed-off-by: savvy-web-bot[bot] <229056750+savvy-web-bot[bot]@users.noreply.github.com>

Updated dependencies:
- node: 26.7.0 -> 26.8.1

Signed-off-by: savvy-web-bot[bot] <229056750+savvy-web-bot[bot]@users.noreply.github.com>

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ No defects found in the bump itself. One informational note below, and one verification gap.

Reviewed changes

  • Node runtime pin — root package.json devEngines.runtime[0].version moves 26.7.026.8.1; nothing else in the diff.

The target checks out. v26.8.1 is published (2026-08-26) and is already in the actions/node-versions manifest, so CI runtime provisioning resolves it rather than falling back to a direct download. It is an out-of-band fix for 26.8.0, whose node --version reported an alpha designation — taking .1 rather than .0 is the right call. Nothing in the 26.7.026.8.1 window touches TypeScript type-stripping, which this repo leans on for node savvy.build.ts. The one candidate worth chasing, module: report unreadable package.json (nodejs/node#65223), does not bite: ReposLockdown locks to 0o444/0o555 (packages/silk-effects/src/repos/services/lockdown.ts:5-6), so vendored .repos/** manifests stay readable. No changeset is expected either — runtime is release-neutral (packages/silk-effects/src/changesets/services/deps-regen.ts:654) and the root workspace is private.

ℹ️ The documented Node requirement no longer matches devEngines

CONTRIBUTING.md:7 states "Node.js 24.11.0+ (see devEngines in package.json)", but devEngines has been on the 26 line since before this PR; CLAUDE.md:27, README.md:137, and .github/copilot-instructions.md:13 repeat the same 24.11.0 figure. Those track engines.node (>=24.11.0, correctly unchanged here), so the numbers are not wrong so much as pointing at the wrong field — but a contributor reading CONTRIBUTING.md installs a Node several majors below what CI actually runs. This predates the PR and is not a reason to hold it; it is worth one follow-up since every runtime bump widens the gap.

Technical details
# Documented Node requirement points at the wrong manifest field

## Affected sites
- `CONTRIBUTING.md:7` — cites `devEngines` as the source for "24.11.0+"; `devEngines.runtime` is on 26.x.
- `CLAUDE.md:27`, `README.md:137`, `.github/copilot-instructions.md:13` — repeat 24.11.0 with no indication that CI runs a different, newer runtime.

## Required outcome
- Contributor-facing docs distinguish the supported floor (`engines.node`, `>=24.11.0`) from the version CI and the devcontainer actually provision (`devEngines.runtime`), so neither number reads as the other's source.

## Open questions for the human
- Is `engines.node: ">=24.11.0"` still the intended published floor, or should it track the 26 line now that `devEngines` does?
- Should `silk-update-action` own these doc strings so they stop drifting on each runtime bump?

Reporting gap: this environment has no way to list check runs, so I could not confirm CI is green on 3c8da95. onFail: "ignore" means no local gate catches a Node 26.8 incompatibility — a passing CI run is the only evidence — so I am not approving despite finding no defects.

Pullfrog  | Fix it ➔View workflow run | Using Claude Opus𝕏

@savvy-web-bot
savvy-web-bot Bot merged commit 61bfdfe into main Aug 28, 2026
17 of 20 checks passed
@savvy-web-bot
savvy-web-bot Bot deleted the pnpm/config-deps branch August 28, 2026 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants