Skip to content

Move Claude review workflows to scality/workflows@v2 - #65

Open
matthiasL-scality wants to merge 1 commit into
mainfrom
improvement/claude-review-v2
Open

matthiasL-scality wants to merge 1 commit into
mainfrom
improvement/claude-review-v2

Conversation

@matthiasL-scality

Copy link
Copy Markdown

Follow-up to the Claude code review migration to Anthropic native authentication.

Changes

  • Move claude-code-dependency-review.yml from 284fcb6 (v2.12.0) to @v2, so the repository follows future v2 releases automatically.
  • Move claude-code-review.yml from 284fcb6 (v2.12.0) to @v2, so the repository follows future v2 releases automatically.
  • Remove GCP_WORKLOAD_IDENTITY_PROVIDER, GCP_SERVICE_ACCOUNT, ANTHROPIC_VERTEX_PROJECT_ID and CLOUD_ML_REGION. They are deprecated and unused since the migration.

No permission change is needed: v2 requires the same job permissions as before (id-token: write included).

@matthiasL-scality
matthiasL-scality requested a review from a team as a code owner October 23, 2026 13:02
@ezekiel-alexrod

Copy link
Copy Markdown
Contributor

Hello @matthiasL-scality, fine for me to drop the GCP secrets.

One question: on the platform repos we pin scality/workflows by SHA with a # vX.Y.Z comment, so Renovate tracks the bumps (target state of MK8S-452). Could we keep @284fcb6c972f27f628e342199064ba8ccd5df8c2 # v2.12.0 instead of @v2?

Unless @v2 is now the recommended way, in which case I'll update our target state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants