Repository navigation
Added rules for ciphers for Crypto library - #3
Closed
jrepucci-rh wants to merge 4 commits into
Closed
jrepucci-rh wants to merge 4 commits into
jrepucci-rh wants to merge 4 commits into
Conversation
The 22 JS crypto algorithm rule files reduce to four distinct rule bodies - the sink patterns are byte-identical across algorithms and only the metavariable-regex and crypto: metadata differ. Keep one file per captured API so each rule has exactly one copy to review: aes (Cipheriv.update / Decipheriv.update and their AEAD variants), sha-2 (Hash.digest), hmac (Hmac.digest). Untrack the other 19 algorithms and their integration fixtures. Removed from the index only - the files remain on disk untouched, so re-adding is a plain git add. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Hi @jrepucci-rh, Thanks, and sorry for the delay. Three things:
|
isasmendiagus
requested changes
Oct 13, 2026
isasmendiagus
left a comment
isasmendiagus
left a comment
There was a problem hiding this comment.
Thanks, and sorry for the delay. Three things:
- The PR conflicts with
main. The AES rules and fixture already landed in #4, so please rebase and remove the AES files from this PR. - The one-shot
crypto.hash('sha256', data)(Node 21.7+) is not detected. Could you add a rule for it, following the same shape asrsa.sign, with a case in the fixture? - Node also accepts uppercase names like
'SHA256'. The AES and RSA rules already handle that with(?i); please do the same here and add a case for it.
|
Closing as agreed. HMAC/SHA-2 rules for Node.js crypto can come back in a new PR if they become a priority. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Checklist
make testpasses locallyopengrep --validateNotes for reviewers