Repository navigation
feat(javascript): add Node.js Crypto rules for ecdsa , eddsa, and Diffie-Hellman + fix RSA gap - #5
Closed
jrepucci-rh wants to merge 3 commits into
Closed
jrepucci-rh wants to merge 3 commits into
jrepucci-rh wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some existing Node.js Crypto rules needed analogues for the ECDSA and EdDSA algorithm families. I also needed to add rules for Diffie-Hellman key exchanges.
Claude also caught a gap on existing RSA rules, so figured I'd fix those as well.
AI Generated by: Claude (using Opus 5)
Type of change
Checklist
make testpasses locallyopengrep --validateNotes for reviewers
Header comments in these files were written by AI and likely inaccurate. View them as notes for the reviewer that may point to blind spots in the patterns. Take them with a grain of salt.