Skip to content

feat(javascript): add Node.js Crypto rules for ecdsa , eddsa, and Diffie-Hellman + fix RSA gap - #5

Closed
jrepucci-rh wants to merge 3 commits into
mainfrom
new_nodejs_algo_families
Closed

jrepucci-rh wants to merge 3 commits into
mainfrom
new_nodejs_algo_families

Conversation

@jrepucci-rh

@jrepucci-rh jrepucci-rh commented Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Some existing Node.js Crypto rules needed analogues for the ECDSA and EdDSA algorithm families. I also needed to add rules for Diffie-Hellman key exchanges.

Claude also caught a gap on existing RSA rules, so figured I'd fix those as well.

AI Generated by: Claude (using Opus 5)

Type of change

  • New rule(s)
  • New / updated test fixtures
  • Bug fix (false positive / false negative)
  • Test framework or tooling
  • Documentation

Checklist

  • New / changed rules have matching test fixtures
  • make test passes locally
  • Rule files validate with opengrep --validate
  • Commits follow Conventional Commits
  • No private or internal data is included in this change

Notes for reviewers

Header comments in these files were written by AI and likely inaccurate. View them as notes for the reviewer that may point to blind spots in the patterns. Take them with a grain of salt.

@jrepucci-rh jrepucci-rh changed the title Add rules for ecdsa and eddsa feat(javascript): add Node.js Crypto rules for ecdsa , eddsa, and Diffie-Hellman Sep 24, 2026
@jrepucci-rh jrepucci-rh changed the title feat(javascript): add Node.js Crypto rules for ecdsa , eddsa, and Diffie-Hellman feat(javascript): add Node.js Crypto rules for ecdsa , eddsa, and Diffie-Hellman + fix RSA gap Sep 25, 2026
@isasmendiagus

Copy link
Copy Markdown

This looks like the union of #6, #7 and #8 (and #8 has a newer version of the DH rules). Can we close it and continue on the split PRs?

@isasmendiagus

Copy link
Copy Markdown

Closing as agreed, superseded by #6, #7 and #8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants