Drop comments that restate the code - #54
Merged
Merged
Conversation
Remove doc comments repeating the member below them and the SCSS section banners, keeping the notes on the Cloudflare route function, the postbuild root-index removal, and the preloaded font face.
Deploying schulywebsite with
|
| Latest commit: |
493e245
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://92f773ae.schulywebsite.pages.dev |
| Branch Preview URL: | https://refactor-53-commentsweep.schulywebsite.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
42 comment lines across 10 files, all of them repeating the declaration underneath or labelling a section.
Kept: why the Pages Function only handles the bare
/route, why postbuild removes the rootindex.htmlso the_redirectsrule applies, and the preloaded Inter font face.The stripper tracks
/* */state, so the universal selectors instyles.scss(* {,*::before,*::after) were not mistaken for comment continuations. Verified with a fullbun run build, postbuild included.Closes #53