feat: add support for reading linked RNTuple attribute sets - #1725
Open
aashirvad08 wants to merge 2 commits into
Open
aashirvad08 wants to merge 2 commits into
aashirvad08 wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for reading linked attribute sets from RNTuples
RNTuple v1.0.1.0 introduced attribute sets as separate linked RNTuples. Uproot was already reading the corresponding footer records but it was not following the locators to actually load the attribute data
And PR exposes them through RNTuple.attributes and adds RNTupleAttributeSet for accessing the user data, ranges and entry-based lookups
It also handles linked RNTuple cache isolation and lazy loading so unsupported attribute schemas only fail when that particular attribute set is accessed
limitation: test_ROOT has not been run because it requires ROOT 6.40 which introduced CreateAttributeSet
closes - #1721